General refactoring and cleanup #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed short name support from scripted builds
* Updated/clarified docs
* `CSemVer` and `CSemVerCI` are now value types.
- SemVer itself is NOT to avoid the problems of exceptions in equality checks or forcing a default comparison for value equality...
* Removed RegEx from `CSemVerCI` in preference to existing Sprache grammar support.
* Removed SemVer.GetComparer as it was redundant and confusing. The static `SemVerComparer` class is usable directly.
* Corrected build scripts to not set short names to $false
- Short name support was removed so there is no such parameter
* Corrected use of default constructor for tests
* corrected docs for FileVersionQuad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General refactoring and cleanup
CSemVerandCSemVerCIare now value types.CSemVerCIin preference to existing Sprache grammar support.SemVerComparerclass is usable directly.