Added more testing and updated code based on results #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Task now validates the pre-release number/fix ONLY when a pre-release name is provided.
- Otherwise the number/fix are irrelevant.
* Adjusted error codes to include the validation of the Fix as it accidentally used the wrong value and therefore, did not have a distinct code.
* Added error code for Missing BuildVersionData element in BuildVersionXml file
- This resulted in an adjustment of error codes.
* Moved clearing of CI info properties to targets file
- This is required to have the correct impact as the props file is imported BEFORE any project file. Thus, anything set in a project file would re-set the value to non-empty which isn't the intended state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more testing and updated code based on results