Skip to content

Updates to account for changes in meaning of FileVersionQuad.Revision LSB #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025

Conversation

smaillet
Copy link
Member

@smaillet smaillet commented Jun 9, 2025

Updates to account for changes in meaning of FileVersionQuad.Reision LSB

  • Specs are silent on the point. Playground indicates that the LSB indicates a CI build (ODD) however, that would place a CI build as a HIGHER sort order than the release form without special understanding. Which won't exist in any OS APIs. So the meaning is inverted and the higher numeric ordering is reserved for release builds allowing for expected comparisons to work.
  • Docs build updates
  • Adjusted the build version to use a patch to the previously released
    RC build.
  • This is OK for the develop branch as nothing has released from it or any other version and the changes are relevant to the updated release.

…` LSB

* Specs are silent on the point playground indicates that the LSB indicates a CI build (ODD) however, that would place a CI build as
a HIGHER sort order than the release form without special understanding. Which won't exist in any OS APIs. So the meaning is
inverted and the higher numeric ordering is reserved for release builds allowing for expected comparisons to work.
* Docs build updates
* Adjusted the build version to use a patch to the previously released
RC build.
* This is OK for the develop branch as nothing has released from it or any other version and the changes are relevant to the updated release.
@smaillet smaillet changed the title Updates to account for changes in meaning of FileVersionQuad.Reision LSB Updates to account for changes in meaning of FileVersionQuad.Revision LSB Jun 9, 2025
Copy link

github-actions bot commented Jun 9, 2025

Test Results

43 tests  ±0   43 ✅ ±0   10s ⏱️ ±0s
 2 suites ±0    0 💤 ±0 
 2 files   ±0    0 ❌ ±0 

Results for commit f157ccc. ± Comparison against base commit 7d90e84.

♻️ This comment has been updated with latest results.

@smaillet smaillet merged commit 5a82142 into UbiquityDotNET:develop Jun 9, 2025
3 checks passed
@smaillet smaillet deleted the UpdateForSpecIssues branch June 9, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant