Added Testing of assembly attributes #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated build scripts to force a rebuild of all projects
- The tests use nuget pkg resolution and would otherwise use whatever package was built last.
* Added targets to PSSPROJ files to allow rebuilds to work
* Marked IDE runs as in conclusive for packaged assembly validation.
- Since tests resolve NUGET packages it isn't deterministic if the package was created via the IDE or a command line build.
- IDE builds are determined by the presence of the environment variable "BuildTime".
- This value is set by the build scripts for ALL of the builds so that all binaries produce the same version number for CI builds. (It is ignored for a release build)
…action that updates a PR comment needs the results.
* It was downright confusing and, obviously now, broke the automated builds
- Now requires existence of a generated props file
* Moved creation of the generated props file to a distinct script to make it easy to generate once for IDE work.
- Directory.Build.Targets contains a check for it and will create an error if not found with a message indicating what to do to resolve the problem.
* Added additional logging to build tasks to aid with diagnostics
- These are now low priority messages so that don't normally appear in output
* Removed determination of build kind from tests as that's a build script only thing not needed in the tests now.
* Sadly the buildIndex from a time stamp is non-deterministic making it impossible to create tests with an exact match.
- Tests would need to adjust to acount for "close enough"
- or, the better answer, I think, is that a new deterministic computation method is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Testing of assembly attributes