Potential fix for code scanning alerts: Workflow does not contain permissions #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
smaillet
changed the title
Permissions are tightened to the point that the Publish test results step will fail on a PR now. It wouldn't do anything for a PR build in the past (except waste CPU cycles) So, this fix just skips the step entirely for PR builds.
Updated syntax of condition cuz, ya know. it's not like there's anything to catch errors ahead of time... [Sigh!] 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/UbiquityDotNET/CSemVer.GitBuild/security/code-scanning/1
To fix the issue, we need to add a
permissionsblock to the workflow. This block should specify the least privileges required for the workflow to function correctly. Based on the operations performed in the workflow, the following permissions are needed:contents: readfor accessing repository contents.contents: writefor committing documentation changes.pages: writefor pushing documentation to GitHub Pages.packages: writefor publishing packages to NuGet.org.actions: readfor interacting with GitHub Actions artifacts.The
permissionsblock can be added at the root level of the workflow to apply to all jobs, or it can be added to individual jobs if different jobs require different permissions.Suggested fixes powered by Copilot Autofix. Review carefully before merging.