Update wheel building to rename linux wheels #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is intended to address the problem that our linux wheels are rejected by PYPI. This is because they are generic linux wheels, rather than complying to a manylinux standard. Previous attempts to repair the wheel to a proper manylinux standard have run into difficulties resulting from the compiled EPANET binaries. Since these binaries are out of our control, it is not possible to quickly resolve this issue.
By renaming our linux wheels to appear as manylinux wheels, pypi should accept them. It is important to recognize that this will likely cause issues on some systems which are not actually compatible with the linux wheel, despite the manylinux name. We have tested the wheel on common ubuntu environments (my personal machine (22.04), GH ubuntu-latest (I assume this is 24.X), and on Google Colab. By forcing the wheel name, these environments should be able to successfully install and use the latest WNTR release despite the current inability to properly repair the linux wheel to manylinux standard.
Tests and documentation
As mentioned, the generic linux wheels have been tested on a handful of ubuntu systems to verify that they will work despite the failure to repair.
Acknowledgement
By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.