Replacing SubsetRandomSampler by RandomSampler in BATCH_SAMPLER #3261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the SubsetRandomSampler by a RandomSampler in the BACH_SAMPLER implementation.
It allows to drop memory usage by a large amount without losing performance or changing the current behavior.
Motivations
Results & tests
Changes
Related Issue
I did not actually open an issue about it, but I can if needed.
Shout-out to @arn4 for finding the reason why simply sampling ids was actually very slow and costly in a resource intensive setup!