Skip to content

multi-GPU support for mine_hard_negatives #2967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 4, 2024
Merged

multi-GPU support for mine_hard_negatives #2967

merged 9 commits into from
Dec 4, 2024

Conversation

alperctnkaya
Copy link
Contributor

Added support for multi-GPU encoding in sentence embeddings with model.encode_multi_process

@tomaarsen tomaarsen changed the base branch from v3.1-release to master October 17, 2024 15:52
@tomaarsen tomaarsen force-pushed the patch-2 branch 2 times, most recently from ab85d71 to 25f1c08 Compare October 17, 2024 15:57
@tomaarsen
Merge branch 'master' into pr-2967
eb5d523
@tomaarsen
Run 'pre-commit run --all'
6e024bb
@tomaarsen
Rename use_multiple_gpus to use_multi_process
b161e5e 
Because this also supports multiple CPUs & multi_process is what the underlying code is called.
Also stop the pools afterwards again
And remove code duplication
@tomaarsen
Copy link
Collaborator

tomaarsen commented Nov 26, 2024 •
edited
Loading

Hello!

Apologies for the delay.
I made some changes to the PR:

  1. Rename use_multiple_gpus to use_multi_process, because it also supports multi-processing for CPUs.
  2. Remove code duplication because the query/corpus embedding is the same regardless of whether faiss is used or not.
  3. Add model.stop_multi_process_pool(pool) to avoid the multiprocessing pool components from being kept unnecessarily.
  4. Added a docstring for use_multi_process
  5. Update use_multi_process so that you can both use True for all GPUs/4 CPUs or a list of devices for more customizability.

I'm curious what you think @alperctnkaya!

  • Tom Aarsen

@alperctnkaya
Copy link
Contributor Author

Looks good to me! It enhances code's clarity and flexibility.

@tomaarsen
Copy link
Collaborator

tomaarsen commented Dec 4, 2024 •
edited
Loading

Excellent, then we're on the same page! Thanks for opening this & having a look at my changes. I'll merge this.

  • Tom Aarsen

@tomaarsen tomaarsen merged commit 679ab5d into UKPLab:master Dec 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaarsen tomaarsen tomaarsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alperctnkaya @tomaarsen