[deps] Attempt to remove numpy restrictions
#2937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
claui
added a commit
to claui/aider
that referenced
this pull request
Mar 5, 2025
Commit 66c24fa pinned NumPy to v1.x due to an upstream incompatibility in sentence-transformers. In September 2024 [1], Aider picked up sentence-transformers v3.1.1, which contains a fix for the NumPy 2 incompatibility [2]. To help unblock PR Aider-AI#3037 [3], bump NumPy to v2.0.2, the most recent version still compatible to Python 3.9. [1]: Aider-AI@2ca093f [2]: UKPLab/sentence-transformers#2937 [3]: Aider-AI#3037
claui
added a commit
to claui/aider
that referenced
this pull request
Mar 8, 2025
Commit 66c24fa pinned NumPy to v1.x due to an upstream incompatibility in sentence-transformers. In September 2024 [1], Aider picked up sentence-transformers v3.1.1, which contains a fix for the NumPy 2 incompatibility [2]. To help unblock PR Aider-AI#3037 [3], bump NumPy to v2.0.2, the most recent version still compatible to Python 3.9. [1]: Aider-AI@2ca093f [2]: UKPLab/sentence-transformers#2937 [3]: Aider-AI#3037
claui
added a commit
to claui/aider
that referenced
this pull request
Mar 9, 2025
Commit 66c24fa pinned NumPy to v1.x due to an upstream incompatibility in sentence-transformers. In September 2024 [1], Aider picked up sentence-transformers v3.1.1, which contains a fix for the NumPy 2 incompatibility [2]. To help unblock PR Aider-AI#3037 [3], bump NumPy to v2.0.2, the most recent version still compatible to Python 3.9. [1]: Aider-AI@2ca093f [2]: UKPLab/sentence-transformers#2937 [3]: Aider-AI#3037
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2933
Hello!
Pull Request overview
Details
I have some good luck with this locally; perhaps some of the problematic third-party dependencies have also been updated to support Numpy. For context: Numpy 2 used to break for Windows: https://github.com/UKPLab/sentence-transformers/actions/runs/9547213601/job/26311747682?pr=2757