Skip to content

Refactor variance thresholding #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 23, 2020
Merged

Refactor variance thresholding #59

merged 3 commits into from
Mar 23, 2020

Conversation

jackyho112
Copy link
Collaborator

@jackyho112 jackyho112 requested review from techrah and removed request for techrah March 23, 2020 22:11
techrah
techrah requested changes Mar 23, 2020
View reviewed changes
@jackyho112
Copy link
Collaborator Author

Tests are failing. I'm checking.

@jackyho112 jackyho112 requested a review from techrah March 23, 2020 22:26
techrah
techrah approved these changes Mar 23, 2020
View reviewed changes
Copy link
Collaborator

@techrah techrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov
Copy link

codecov bot commented Mar 23, 2020 •
edited
Loading

Codecov Report

Merging #59 into master will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   95.68%   95.61%   -0.08%     
==========================================
  Files           4        4              
  Lines         116      114       -2     
==========================================
- Hits          111      109       -2     
  Misses          5        5
Impacted Files Coverage Δ
R/variance_thresholding.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae608c0...035fc4d. Read the comment docs.

@jackyho112
Copy link
Collaborator Author

I will add a test

@jackyho112 jackyho112 merged commit 9d07dd6 into master Mar 23, 2020
@jackyho112 jackyho112 deleted the refactor-variance-thresholding branch March 23, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techrah techrah techrah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackyho112 @techrah