-
Notifications
You must be signed in to change notification settings - Fork 15
PDF hover tooltip fix #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…pdf/html image display
Hmm, it seems to be working for me with the latest updates on main and a cleared build directory. Any chance there is something in old in your build directory that interferes with building the new pdf file? |
…clrblnd friendly)
You're right -- I needed to clean out my This PR should be good to review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
glue('can_lang_plot_tooltip', Image('img/viz/languages_with_mouse.png'), display=False) | ||
else: | ||
# Increasing the dimensions makes all the ticks fit in jupyter book (the fit with the default dimensions in jupyterlab) | ||
glue('can_lang_plot_tooltip', can_lang_plot_tooltip.properties(height=320, width=420), display=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix
This reverts commit 333ba4d.
@joelostblom in the PDF version the image is too big. I can't seem to shrink it...shrinking the actual file itself didn't help, nor did setting |
Are you able to add a If that is not possible, is there any latex directive that could be used? Like setting the image size globally just before this figure and then setting it back? |
I've tried a few other things, and nothing seems to work -- either the image disappears entirely, or it appears but is too big. I am going to merge this anyway because the HTML build is fine, and the PDF build is improved but not perfect yet. Once the changes are limited to just "make the PDF build work for print" I'll return to this. |
Closes #175
But I can't test it yet. @joelostblom #171 appears to be a problem still even after the PR in #218
Was there a regression somewhere? Or did the new Dockerfile build that just happened for #240 break things?