Refactor opacity parsing and add percent/number converters #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated OpacityPropertyTests to include additional test cases for parsing opacity values and modified expected results for existing tests. Added ToPercentOrNumber method to ValueExtensions for parsing tokens as percentages or numbers. Introduced PercentOrNumberConverter and OptionalPercentOrNumberConverter in Converters, with the latter providing a default value of 1. Modified OpacityProperty to use OptionalPercentOrNumberConverter. Updated Number class to include a Percent as an unit in the Unit enum and modified ToString methods to append '%' for Percent unit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support for percentage values for the "opacity" property, introduced with 4.2.6, results in percentage values being applied to the property after parsing, regardless of the input value.
With this pull request, the behavior has been changed so that a percentage value is only applied if the input was a percentage value.
For this, the "Number" struct was extended with the Percent unit, and appropriate converter methods were added. Additionally, the unit tests were adjusted accordingly.