Expose font default values #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are cases where a declaration of font: inherit/initial/unset can matter so they should be exposed so consuming applications can make the correct decision. There are cases when these values should override any other font properties that may have been set by other css style selectors (depending on factors such as origin stylesheet, specificity, positioning, and importance tags).
TylerBrinks
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where a declaration of a font: inherit/initial/unset can matter, so they should be exposed to allow consuming applications to make the correct decision.
For more context, there are cases when these values should override any other font properties that may have been set by other css style selectors (depending on factors such as origin stylesheet, specificity, positioning, and importance tags). An example of what I mean can be found here: https://stackoverflow.com/questions/12880536/what-is-the-purpose-of-using-font-inherit
The example in the answer from that post is not referring to the font property, but the same concept applies. If the font-weight is set to bold on all elements td, but at the same time that same td also has class attributed to it that sets font: inherit (or initial or unset etc.), then that bold font-weight will no longer apply. This is why we need this library to expose such values so this determination can be done by the consuming application.