Skip to content
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

[TT-8392] Add extra volumes and extra volume mounts support #264

Merged
merged 6 commits into from
Mar 29, 2023

Conversation

zalbiraw
Copy link

@zalbiraw zalbiraw commented Mar 22, 2023

Add support for extraVolumes and extraVolumeMounts to allow users to mount volumes to our containers

Also fixes the extraEnvs and add support for yaml based input rather than key, value pairs

Solves
#246
#261

Description

Related Issue

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zalbiraw zalbiraw requested a review from a team as a code owner March 22, 2023 18:43
@zalbiraw zalbiraw requested review from andrei-tyk and removed request for a team March 22, 2023 18:43
@zalbiraw zalbiraw force-pushed the add-extraVolumes-and-extraVolumeMounts-support branch from 9420051 to 1c7382a Compare March 22, 2023 18:59
@zalbiraw zalbiraw changed the title Add extra volumes and extra volume mounts support [TT-8373] Add extra volumes and extra volume mounts support Mar 22, 2023
@zalbiraw zalbiraw mentioned this pull request Mar 23, 2023
9 tasks
@zalbiraw zalbiraw changed the title [TT-8373] Add extra volumes and extra volume mounts support [TT-8373][TT-8360] Add extra volumes and extra volume mounts support Mar 23, 2023
@buraksekili buraksekili changed the title [TT-8373][TT-8360] Add extra volumes and extra volume mounts support [TT-8392] Add extra volumes and extra volume mounts support Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants