Skip to content
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

TT-7026 Add secret hashes #238

Merged
merged 3 commits into from
Nov 11, 2022
Merged

TT-7026 Add secret hashes #238

merged 3 commits into from
Nov 11, 2022

Conversation

zalbiraw
Copy link

Description

Currently, if you update secrets in from the values.yaml that does not trigger deployment updates. Adding the secrets hashes to the deployment annotation seems to be the recommended approach to solving this issue per helm chart docs

https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments

Related Issue

Motivation and Context

Test Coverage For This Change

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If PRing from your fork, don't come from your master!
  • Make sure you are making a pull request against our master branch (left side). Also, it would be best if you started your change off our latest master.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zalbiraw zalbiraw requested a review from a team as a code owner October 15, 2022 15:51
@zalbiraw zalbiraw requested review from bojank93 and removed request for a team October 15, 2022 15:51
@zalbiraw zalbiraw changed the base branch from master to add-enterprise-portal October 15, 2022 15:54
Copy link
Collaborator

@buraksekili buraksekili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @zalbiraw.

@buraksekili
Copy link
Collaborator

since #222 is already merged, i will change this PR's base branch to master again. FYI @zalbiraw
This PR still requires testing from @singhpr.

@buraksekili buraksekili changed the base branch from add-enterprise-portal to master October 18, 2022 11:18
@zalbiraw zalbiraw force-pushed the add-secret-hashes branch 6 times, most recently from 2dd10d9 to fa9a61c Compare October 18, 2022 16:34
@zalbiraw
Copy link
Author

Thank you @buraksekili. I rebased the branch to master!

@buraksekili
Copy link
Collaborator

@zalbiraw sorry for you informing you late but can you please add a one-liner that explains your change on CHANGELOG? sorry, it totally slipped my mind.

@zalbiraw
Copy link
Author

@buraksekili done!

@caroltyk caroltyk changed the title Add secret hashes TT-7026 Add secret hashes Nov 8, 2022
@singhpr singhpr merged commit b10afc8 into master Nov 11, 2022
@zalbiraw zalbiraw deleted the add-secret-hashes branch November 28, 2022 22:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants