[state]: state api refactor. #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tanghaodong25
commented
Nov 14, 2024
•
tanghaodong25
commented
- refactor store api.
- add store development document README.
- delete seldom used features.
|
|
tanghaodong25
changed the title
tanghaodong25
force-pushed
the
state-api-refactor
branch
from
025579c to
13a1041
Compare
tanghaodong25
force-pushed
the
state-api-refactor
branch
3 times, most recently
from
bb993e3 to
5010725
Compare
tanghaodong25
force-pushed
the
state-api-refactor
branch
from
5010725 to
87bc410
Compare
tanghaodong25
force-pushed
the
state-api-refactor
branch
from
175fd19 to
0279051
Compare
Loognqiang
reviewed
Nov 20, 2024
Loognqiang
reviewed
Nov 20, 2024
| this.fetchFun = fetchFun; | ||
| this.iterator = keys.iterator(); | ||
| if (pushdown.getFilters() != null) { | ||
| StatePushDown simpleKeyPushDown = StatePushDown.of() | ||
| .withEdgeLimit(pushdown.getEdgeLimit()) | ||
| .withOrderFields(pushdown.getOrderFields()); | ||
| .withEdgeLimit(pushdown.getEdgeLimit()).withOrderFields(pushdown.getOrderFields()); |
There was a problem hiding this comment.
The change has resulted in an unreasonable format
There was a problem hiding this comment.
issue has been resolved.
.../geaflow-store-cstore/src/main/java/com/antgroup/geaflow/store/cstore/StaticGraphCStore.java
Outdated
Show resolved
Hide resolved
| String sql = String.format(insertFormat, | ||
| this.tableName, this.pk, Joiner.on(',').join(columns), | ||
| String sql = String.format(insertFormat, this.tableName, this.pk, | ||
| Joiner.on(',').join(columns), |
There was a problem hiding this comment.
, should be defined constant value
There was a problem hiding this comment.
issue has been resolved.
...e/geaflow-store-jdbc/src/test/java/com/antgroup/geaflow/store/jdbc/JdbcStoreBuilderTest.java
Outdated
Show resolved
Hide resolved
...store-memory/src/main/java/com/antgroup/geaflow/store/memory/BaseStaticGraphMemoryStore.java
Outdated
Show resolved
Hide resolved
| @@ -47,13 +47,13 @@ | |||
| import java.util.function.BiFunction; | |||
| import java.util.stream.Collectors; | |||
|
|
|||
| public class GraphMemoryMultiVersionedStore<K, VV, EV> extends BaseGraphStore implements | |||
| IGraphMultiVersionedStore<K, VV, EV> { | |||
| public class MemoryDynamicGraphStore<K, VV, EV> extends BaseGraphStore implements | |||
There was a problem hiding this comment.
MemoryDynamicGraphStore -> DynamicGraphMemoryStore
There was a problem hiding this comment.
issue has been resolved.
...e-rocksdb/src/main/java/com/antgroup/geaflow/store/rocksdb/DynamicRocksdbGraphStoreBase.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.