Use gcc-4.8 for GHA legacy tests (open-telemetry#207)

Johannes Tax · web-flow · commit 94cdc7033f01 · 2020-07-23T09:52:06.000-07:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -55,6 +55,8 @@ jobs:
         sudo ./ci/install_gcc48.sh
     - name: run tests
       run: ./ci/do_ci.sh bazel.legacy.test
+      env:
+        CC: /usr/bin/gcc-4.8
 
   bazel_test:
     name: Bazel
diff --git a/exporters/ostream/src/span_exporter.cc b/exporters/ostream/src/span_exporter.cc
@@ -11,7 +11,7 @@ namespace exporter
 namespace trace
 {
 OStreamSpanExporter::OStreamSpanExporter(std::ostream &sout) noexcept
-                                    : sout_{sout} {}
+                                    : sout_(sout) {}
 
 std::unique_ptr<sdktrace::Recordable> OStreamSpanExporter::MakeRecordable() noexcept 
 {

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ namespace exporter`
`11`	`11`	`namespace trace`
`12`	`12`	`{`
`13`	`13`	`OStreamSpanExporter::OStreamSpanExporter(std::ostream &sout) noexcept`
`14`		`- : sout_{sout} {}`
	`14`	`+ : sout_(sout) {}`
`15`	`15`
`16`	`16`	`std::unique_ptr<sdktrace::Recordable> OStreamSpanExporter::MakeRecordable() noexcept`
`17`	`17`	`{`