Moving a temporary object prevents copy elision. (open-telemetry#205)

g-easy · web-flow · commit e61663632cf3 · 2020-07-23T08:45:43.000-07:00
Caught by: -Wpessimizing-move
diff --git a/api/include/opentelemetry/context/context.h b/api/include/opentelemetry/context/context.h
@@ -116,7 +116,7 @@ class Context
       {
         if (first)
         {
-          *node = std::move(DataList(iter.first, iter.second));
+          *node = DataList(iter.first, iter.second);
           first = false;
         }
         else

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ class Context`
`116`	`116`	`{`
`117`	`117`	`if (first)`
`118`	`118`	`{`
`119`		`- *node = std::move(DataList(iter.first, iter.second));`
	`119`	`+ *node = DataList(iter.first, iter.second);`
`120`	`120`	`first = false;`
`121`	`121`	`}`
`122`	`122`	`else`