Skip to content

verifyHMAC requires that the binary secret be a string #89

Open
@dantman

Description

@dantman

Right now verifyHMAC asserts that secret is a string. This secret is used for createHmac.

Hmac secrets work with binary data, so when a string is used that means it converts that to the utf8 binary representation of that text to use as the secret.

In comparison the Python library I used required that the secret be a binary type (bytes).

I think it would be fair for verifyHMAC to allow the secret to be a Buffer.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions