chore: define build & package scripts #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto-loads the correct Node version for many different version managers
We use a dedicated tsconfig file that only selects the files we need for the package.
Closed
rickdgeerling
force-pushed
the
chore/build-scripts
branch
2 times, most recently
from
5be39d2 to
0cf2c80
Compare
Tested package with yalc
rickdgeerling
force-pushed
the
chore/build-scripts
branch
from
0cf2c80 to
1b9786a
Compare
thiagomini
reviewed
Jan 12, 2024
package.json
Outdated
| "engines": { | ||
| "node": ">=20.9.0", | ||
| "yarn": ">=4.0.2" | ||
| }, | ||
| "scripts": { | ||
| "tsc": "tsc", | ||
| "prepublish": "tsc", |
There was a problem hiding this comment.
I believe we should also make sure all tests are passing and style is correct, thoughts @tuxmachine ?
There was a problem hiding this comment.
I agree, but that can be enforced in CI right? This is just ensuring that whenever we publish a package, we build a fresh package, and don't accidentally upload an outdated libs folder.
There was a problem hiding this comment.
As of npm@5, prepublish scripts are deprecated. Use prepare for build steps and prepublishOnly for upload-only.
prepublish is deprecated Co-authored-by: Tolga Paksoy <[email protected]>
rickdgeerling
force-pushed
the
chore/build-scripts
branch
from
2947035 to
b421622
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo: