feat: rule warns when token duplicates type #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagomini
commented
Dec 18, 2023
| description: 'Ensure proper use of the @Inject decorator', | ||
| recommended: 'recommended', | ||
| }, | ||
| fixable: undefined, |
There was a problem hiding this comment.
Making this rule fixable in some cases would be nice too, @tuxmachine - but probably a work for another issue, since it's a bit harder to do it
src/ast-traverser.util.ts
Outdated
| @@ -55,3 +55,22 @@ export function firstAssignmentExpressionInParentChain( | |||
| AST_NODE_TYPES.AssignmentExpression | |||
| ); | |||
| } | |||
|
|
|||
| export function injectDecoratorFor(node: TSESTree.Node) { | |||
There was a problem hiding this comment.
🌽 Corn: Non-blocking, stylistic preference or nitpick
My feedback is categorized into one of five levels:
- 🌱 Non-blocking, question
- 🌽 Corn: Non-blocking, stylistic preference or nitpick
- 🥚 Egg: Non-blocking, future consideration
- 🐤 Chick: Non-blocking, requires future action
- 🐔 Chicken: Blocking
- 🦕 Dinosaur: Blocking, requires immediate action
Can we rename this function to suggest that it returns the @Inject decorator. Now the name suggests that it injects a given decorator, so I was already looking for a second parameter 😄
There was a problem hiding this comment.
Ohh, good catch, I didn't notice that 'inject' could read as a verb here haha
…hub.com:TrilonIO/eslint-plugin into feat/rule-for-correct-usage-of-inject-decorator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2