This repository was archived by the owner on Jun 22, 2025. It is now read-only.
fix(tree): Unexpected collapse after hoisting a note #2293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
eliandoran
approved these changes
Jun 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, after opening settings and hoisting a note, clicking a node causes the tree to suddenly collapse.
The issue can be easily reproduced by changing
600 * 1000to3 * 1000inapps\client\src\widgets\note_tree.ts.After hoisting a note,
branch.isExpandedshould be set totrueto preventupdateNodefrom mistakenly treating the node as unexpanded and collapsing it.