Skip to content

Make ccompat.h less retard. #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make ccompat.h less retard. #835

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 8, 2018

<alloca.h> is Linux-specific header. Also <stdlib.h> may be used instead of <alloca.h> on Linux, so basically it is a useless header.


This change is Reviewable

<alloca.h> is Linux-specific header. Also <stdlib.h> may be used instead of <alloca.h> on Linux, so basically it is a useless header.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ghost
Copy link
Author

ghost commented Mar 8, 2018

@CLAassistant who the fuck are those many open source projects? Fuck your licenses.

@iphydf iphydf closed this Mar 8, 2018
@ghost
Copy link
Author

ghost commented Mar 8, 2018

@iphydf what have you done? FreeBSD is not the only OS which doesn't have <alloca.h>

@iphydf
Copy link
Member

iphydf commented Mar 9, 2018

What I observed: someone opens a PR talking about "retarded" headers, then that someone starts swearing at a bot and deletes the repository fork this PR was made from.

This makes me think that someone is clearly no longer interested in contributing, so I'll helpfully close the PR. If I was wrong, I am happy to chat about any technical or organisational issues you see and would like to fix.

@ghost
Copy link
Author

ghost commented Mar 9, 2018

@iphydf removing fork doesn't prevent from merging changes, I simply don't need the copy of this repository, that's why I always remove local copy after creating retard PR

@iphydf
Copy link
Member

iphydf commented Mar 9, 2018

Ok, can you reopen the PR then?

@ghost
Copy link
Author

ghost commented Mar 9, 2018

@iphydf oh, I see the change is too hard to reproduce. I'll just store the diff locally.

@iphydf iphydf added this to the v0.2.1 milestone Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants