Fix(cicd_bot): Don't truncate backfill model list #4915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erindru
force-pushed
the
erin/cicd-bot-large-model-count
branch
from
883786a to
5ed8082
Compare
erindru
commented
Jul 7, 2025
| @@ -298,7 +298,7 @@ def test_merge_pr_has_non_breaking_change( | |||
| assert GithubCheckConclusion(prod_plan_preview_checks_runs[2]["conclusion"]).is_success | |||
|
|
|||
| expected_prod_plan_directly_modified_summary = """**Directly Modified:** | |||
| * `sushi.waiter_revenue_by_day` (Non-breaking) | |||
| * `memory.sushi.waiter_revenue_by_day` (Non-breaking) | |||
There was a problem hiding this comment.
This is a side effect of setting Verbosity.VERY_VERBOSE.
However, it does have the effect of making the output of this step more closely align with the PR Environment Synced step which is using fully qualified names already
georgesittas
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4120
Currently, if there are lots of models to backfill, we "helpfully" truncate the list in the
Prod Plan Previewstep:However, this is undesirable in the CI/CD bot because there is no equivalent of the
-vvoption to set the output verbosity. This means anyone reviewing the bot output has no way of actually knowing the full extent of the models to be backfilled.This PR updates the CI/CD bot to always show the full list of models affected:
