Fix: Ensure correct datatypes are fetched for RisingWave dialect #4903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
georgesittas
reviewed
Jul 4, 2025
georgesittas
approved these changes
Jul 7, 2025
tests/core/engine_adapter/integration/test_integration_risingwave.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jo <[email protected]>
Thank you for the guidance and the quick replies! I have applied your suggestions now and look forward to seeing it merged. |
erindru
approved these changes
Jul 7, 2025
| if not resp: | ||
| raise SQLMeshError(f"Could not get columns for table {table_name}. Table not found.") | ||
| return { | ||
| column_name: exp.DataType.build(data_type, dialect=self.dialect, udt=True) |
There was a problem hiding this comment.
I had to check what udt=True does but it looks like we still try to parse into a known datatype and only use a user-defined type as a fallback, so this LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, the RisingWave dialect used the
BasePostgressAdapterimplementation ofdef columns(..)to fetch column names and data-types.However the PG catalog tables in RisingWave doesn't support e.g.
structtypes instead returning???as datatype. This PR updates the RisingWave adapter to use the RisingWave catalogs instead to get correct datatypes.Edit: Also added a integration test file for RisingWave upon request of maintainers for the columns function.