Feat: Add support for configurable cache directory #4869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erindru
reviewed
Jul 1, 2025
tests/core/test_context.py
Outdated
| ) | ||
| ), | ||
| model_defaults=model_defaults, | ||
| cache_dir="{custom_cache_dir}", |
There was a problem hiding this comment.
I think injecting the path as a quoted string here is breaking the tests on Windows, because it ends up being cache_dir="C:\some\path" and the \ is treated as an escape
There was a problem hiding this comment.
thanks you’re right updated the test to use as posix to have forward slashes in all platforms
erindru
reviewed
Jul 1, 2025
sqlmesh/core/config/scheduler.py
Outdated
| @@ -105,7 +105,7 @@ def create_state_sync(self, context: GenericContext) -> StateSync: | |||
|
|
|||
| schema = context.config.get_state_schema(context.gateway) | |||
| return EngineAdapterStateSync( | |||
| engine_adapter, schema=schema, context_path=context.path, console=context.console | |||
| engine_adapter, schema=schema, context_path=context.cache_dir, console=context.console | |||
There was a problem hiding this comment.
Should the context_path parameter be renamed to cache_dir?
There was a problem hiding this comment.
yes good point renamed to use the cache_dir name here and everywhere else that I was using cache_path for consistency
themisvaltinos
force-pushed
the
themis/cache
branch
from
5c35a90 to
cca8703
Compare
erindru
approved these changes
Jul 2, 2025
themisvaltinos
force-pushed
the
themis/cache
branch
from
cca8703 to
6bd9463
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default SQLMesh stores its cache in a
.cachefolder inside the project directory. This introduces a configuration option to specify a custom cache location, either as a relative path or an absolute path. Fixes: #4307