Skip to content

AT-378 add prompt for US(copy of the default prompts) #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

AT-378 add prompt for US(copy of the default prompts) #63

wants to merge 1 commit into from

Conversation

anikolaiev
Copy link

No description provided.

@anikolaiev anikolaiev requested a review from redvex December 4, 2024 16:51
redvex
redvex requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@redvex redvex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not necessary at the moment, if you read my comment on the ticket, we want the tutor to default to the prompt on the root folder if the specific country version is not present.

@anikolaiev anikolaiev closed this Dec 4, 2024
@anikolaiev anikolaiev deleted the AT-378-us-prompt branch December 4, 2024 17:05
@redvex
Copy link
Contributor

redvex commented Dec 4, 2024

You may want to create the tutor.md file only in the us folder and change:

  • "maths" -> "math"
  • "British English -> "American English"
  • "UK" -> "US"
  • "who is in year" -> "who is in grade"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redvex redvex redvex requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anikolaiev @redvex