chore(dev deps) - Upgrade all remaining dependencies #246

spanishpear · 2025-04-26T10:45:15Z

Yarn v1 is frozen, and not receiving bugfixes or features anymore!

This PR migrates manypkg internally to use yarn 4 instead :)

There should be no breaking changes to the usages.

Will have to fix some things in CI 🕸️

changeset-bot · 2025-04-26T10:45:18Z

🦋 Changeset detected

Latest commit: c580241

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@manypkg/gatsby-source-workspace	Minor
@manypkg/get-packages	Minor
@manypkg/find-root	Minor
@manypkg/tools	Minor
@manypkg/cli	Minor
test-gatsby-thing	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

spanishpear · 2025-04-26T10:45:43Z

package.json

@@ -41,7 +41,7 @@
    "prettier-plugin-packagejson": "^2.5.10",
    "typescript": "^5.3.2"
  },
-  "packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e",
+  "packageManager": "yarn@4.9.1+sha512.f95ce356460e05be48d66401c1ae64ef84d163dd689964962c6888a9810865e39097a5e9de748876c2e0bf89b232d583c33982773e9903ae7a76257270986538",


SHA generated via corepack upnodejs/corepack#231 (comment)

socket-security · 2025-04-26T12:52:17Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	react@19.1.0

View full report

spanishpear · 2025-04-26T12:52:24Z

__fixtures__/basic-with-scripts/yarn.lock

We need a basic yarn lock, else the tests will fail when running yarn scripts - as they will all error with "this package isn't part of the yarn workspace of manypkg

spanishpear · 2025-04-26T12:53:55Z

packages/cli/src/__snapshots__/run.test.ts.snap

@@ -22,27 +17,17 @@ exports[`Run command should execute "package start" and exit with 1: stderr 1`]

 exports[`Run command should execute "package start" and exit with 1: stdout 1`] = `""`;

-exports[`Run command should execute "package-one start" and exit with 0: stderr 1`] = `
-"warning package.json: No license field


This error doesn't exist anymore in yarn berry - https://github.com/search?q=repo%3Ayarnpkg%2Fberry++%22No+license+field%22&type=code

Was not fun to debug that 😆

spanishpear · 2025-04-26T12:54:22Z

packages/cli/src/run.test.ts


-const f = fixturez(__dirname);
+const f = fixturez(import.meta.url);
+const require = createRequire(import.meta.url);


Added in order to get tests running with ESM

spanishpear · 2025-04-26T12:56:25Z

tsconfig.json

    "allowImportingTsExtensions": true,
+    "skipLibCheck": true,


skipLibCheck to avoid typechecking external .d.ts files - that have errors in them - mostly due to gatsby/react/JSX upstream issues :(

fix: typo with corepack (2) feat: basic yarn cache, and correct args fix: remove yarn cache, action requires different orderings fix: attempt cache with differrent orderings fix: attempt to remove chicken egg problem with cache formatting

spanishpear · 2025-04-26T13:10:56Z

package.json

@@ -13,35 +13,39 @@
    "postinstall": "preconstruct dev && NODE_OPTIONS=--experimental-strip-types packages/cli/bin.js check",
    "knip": "knip",
    "release": "preconstruct build && changeset publish",
-    "test": "jest",
+    "test": "NODE_OPTIONS='--disable-warning=ExperimentalWarning --experimental-vm-modules' jest",


tell jest to run with ESM as per https://jestjs.io/docs/ecmascript-modules

Andarist · 2025-04-26T14:10:53Z

knip.json

+  "jest": {
+    "config": ["package.json"],
+    "entry": [
+      "**/__tests__/**/*.ts",
+      "**/?(*.)+(test).ts",
+      "**/__fixtures__/**/*.[jt]s"
+    ]
+  }


q: what do we need this for?

For some reason knip was failing to automaticaly detect our jest usage, and hence marking most of the test files as unused files.

Andarist · 2025-04-26T14:12:23Z

packages/cli/src/run.test.ts

@@ -35,7 +37,8 @@ describe("Run command", () => {
            cwd: f.find("basic-with-scripts"),
            env: {
              ...process.env,
-              NODE_OPTIONS: "--experimental-strip-types",
+              NODE_OPTIONS:
+                "--experimental-strip-types --disable-warning=ExperimentalWarning",


does this make stripNodeWarnings obsolete?

Andarist · 2025-04-26T14:14:36Z

packages/cli/src/run.test.ts

@@ -1,8 +1,10 @@
 import fixturez from "fixturez";
 import stripAnsi from "strip-ansi";
 import { exec } from "tinyexec";
+import { createRequire } from "node:module";


We could replace this with https://www.npmjs.com/package/import-meta-resolve , but honestly using either is just equally fine given this is a test file anyway

Andarist · 2025-04-26T14:24:34Z

packages/cli/src/test-helpers.ts

@@ -4,7 +4,7 @@
 //
 // Who can say? ¯\_(ツ)_/¯

-import { Package } from "@manypkg/get-packages";
+import type { Package } from "@manypkg/get-packages";


We should use erasableSyntaxOnly + verbatimModuleSyntax to catch issues like this

I see you have already enabled both 👍

Andarist · 2025-04-26T14:26:06Z

tsconfig.json

@@ -3,9 +3,11 @@
    /* Basic Options */
    // "incremental": true,                   /* Enable incremental compilation */
    "target": "esnext" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */,
-    "module": "Node16" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */,
-    //"erasableSyntaxOnly": true, - we need TS 5.8 first
+    "module": "nodenext" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */,


Node16 (or Node18) is, kind of, a safer value

Andarist · 2025-04-26T14:26:45Z

tsconfig.json

@@ -26,7 +28,8 @@

    /* Strict Type-Checking Options */
    "strict": true /* Enable all strict type-checking options. */,
-    // "noImplicitAny": true,                 /* Raise error on expressions and declarations with an implied 'any' type. */
+    "noImplicitOverride": true /* Ensure overriding members in derived classes are marked with an explicit override modifier. */,
+    "noImplicitAny": true /* Raise error on expressions and declarations with an implied 'any' type. */,


this is already enabled through strict: true

oh, it is too!

Andarist · 2025-04-26T22:01:50Z

Given @bluwy's migration to Vitest... I think I'd close this one and split the work into slightly smaller pieces. I'm in favor of migrating the repo to pnpm so migrating (temporarily) to yarn 4 doesn't bring much value. With that migration in - we should then bump all the dependencies.

spanishpear · 2025-04-27T05:10:24Z

Makes sense @Andarist - will probably wait for the decision on gatsby package removal (#247) as well :D

spanishpear added 3 commits April 26, 2025 20:43

chore: update yarn to 4.9.1

6e9a7e1

corepack enable for yarn

744af65

use SHA for yarn (generated via corepack up)

67109bb

spanishpear commented Apr 26, 2025

View reviewed changes

spanishpear marked this pull request as draft April 26, 2025 11:08

spanishpear commented Apr 26, 2025

View reviewed changes

spanishpear added 2 commits April 26, 2025 23:00

fix: typo with corepack

bb40696

fix: typo with corepack (2) feat: basic yarn cache, and correct args fix: remove yarn cache, action requires different orderings fix: attempt cache with differrent orderings fix: attempt to remove chicken egg problem with cache formatting

feat: update remainding deps, fix knip, fix typescript; fix tests

db89e4d

spanishpear force-pushed the spanishpear/yarn-upgrade-4.9 branch from b6fd466 to db89e4d Compare April 26, 2025 13:00

changeset

c580241

spanishpear commented Apr 26, 2025

View reviewed changes

spanishpear marked this pull request as ready for review April 26, 2025 13:13

spanishpear changed the title ~~chore(dev deps) - upgrade yarn from 1.22.1 -> 4.9.1~~ chore(dev deps) - Upgrade all remaining dependencies Apr 26, 2025

Andarist reviewed Apr 26, 2025

View reviewed changes

spanishpear closed this Apr 27, 2025

chore(dev deps) - Upgrade all remaining dependencies #246

chore(dev deps) - Upgrade all remaining dependencies #246

Uh oh!

Conversation

spanishpear commented Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Choose a reason for hiding this comment

Uh oh!

socket-security bot commented Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spanishpear Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Andarist commented Apr 26, 2025

Uh oh!

spanishpear commented Apr 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

spanishpear commented Apr 26, 2025 •

edited

Loading

changeset-bot bot commented Apr 26, 2025 •

edited

Loading

socket-security bot commented Apr 26, 2025 •

edited

Loading

spanishpear Apr 26, 2025 •

edited

Loading

spanishpear commented Apr 27, 2025 •

edited

Loading