Restore support for Bolt monorepos #174
Conversation
🦋 Changeset detectedLatest commit: 5e60c8f The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| packageJson: PackageJSON; | ||
| dir: string; | ||
| relativeDir: string; | ||
| } |
There was a problem hiding this comment.
I added Tool and Package here as Packages (below) refers to them. Not sure if that's needed/wanted. Happy to remove.
There was a problem hiding this comment.
perhaps we should refer to them as import('@manypkg/tools').Tool etc? This way we wouldn't have to worry about syncing those definitions in READMEs and it would be clear from where they are coming from here
Co-authored-by: Mateusz Burzyński <[email protected]>
packages/find-root/src/index.ts
Outdated
| @@ -21,6 +22,7 @@ import { | |||
| */ | |||
| const DEFAULT_TOOLS: Tool[] = [ | |||
| YarnTool, | |||
| BoltTool, | |||
There was a problem hiding this comment.
would it work if we'd put BoltTool at the end?
There was a problem hiding this comment.
Yeah, it still works. I moved it down. It's still above RootTool as it seems likeRootTool should always be last.
Anything else or are we good to merge?
This addresses #172 by reverting #165, with some minor modifications that I've annotated in comments.