-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix paused prop doesn't work when init the Video #625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It caused by onResume life cycle method.
Very important fix :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one problem in this approach: if the video is playing and onHostPause is triggered, the video would not resume when onHostResume because onHostPause will invoke setPausedModifier(true);
Life saver, please merge this! |
I think the latest master branch already fixed this |
In master package.json file, version is 1.1.0, but on |
Manually added "mActiveStatePauseStatus = paused;" to my ReactVideoView.java file. But videos continue to autoplay. Here is what I have (RN - 0.44; react-native-video - 2.0.0) - |
Does anybody maintain this library anymore? We need these PRs merged, if possible. Thanks! |
I reworked this in #1082 so we don't even need the active status paused field. In my testing everything is working properly now. Will be released in 3.0. |
It caused by onResume life cycle method. when the first time to run onResume, the mActiveStatePauseStatus always be false, so it always play the video.
now we can use paused prop to control the video playing status.