Skip to content

Adding Docker Build Actions #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Fenikkusu
Copy link
Contributor

@Fenikkusu Fenikkusu commented Oct 4, 2023

Adding Docker Build Actions

Adds GitHub Actions to Build Images and store them in the GitHub Container Registry

@Fenikkusu
Copy link
Contributor Author

I'm going to need some guidance on this: The pipeline is running, but the build of the ML API is failing with an error indicating the specific commit hash is missing. As I'm not very familiar with the inner workings of what Obico is supposed to be, I'm not sure of the best path forward in terms of establishing a replacement hash.

https://github.com/Fenikkusu/obico-server/actions/runs/6411698671/job/17407684714

@Fenikkusu
Copy link
Contributor Author

Nvm, I had a stupid moment. I realized the issue.

@Fenikkusu Fenikkusu changed the title [WIP] Adding Docker Build Actions Adding Docker Build Actions Oct 6, 2023
@Fenikkusu
Copy link
Contributor Author

Okay, I think this should be good now, at least as a first pass.

@Fenikkusu Fenikkusu force-pushed the master-docker-build branch from 488514d to 667794e Compare October 6, 2023 05:04
@kennethjiang kennethjiang merged commit 1b57c8b into TheSpaghettiDetective:master Oct 7, 2023
@kennethjiang
Copy link
Contributor

Thank you for the PR. LGTM! And sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants