Skip to content

Improve Sharphound and Azurehound installations #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 8, 2024

Conversation

gbe
Copy link
Contributor

@gbe gbe commented Oct 24, 2024

Howdy,

this PR aims at improving the installation of the ingestors Sharphound and Azurehound for Bloodhound-CE:

  • the case of local variables is switched from uppercase to lowercase for consistency across Exegol
  • local paths are put into a variable instead of repeating each time the same paths
  • instead of Curling the same Github page several times, the result is put once into a temporary file
  • instead of Grepping the json output of Github, the temporary file is parsed with jq
  • fix the variable azurehound_url_amd64 that was containing the arm64 URL, and the other way around the arm64 variable contained the amd64 URL
  • A sha256 file was computed locally but nothing was done with it. Instead, the sha256files for Azurehound are downloaded from Github and the integrity of the zip archives is check prior to unzipping them.
  • As upstream does not provide a sha256 file for Sharphound, the file computed locally is removed in order to not give a false impression that it was downloaded from Github.

@qu35t-code qu35t-code self-assigned this Oct 24, 2024
@qu35t-code qu35t-code added bugfix It's a bird, it's a plane under review labels Oct 24, 2024
@qu35t-code
Copy link
Member

@gbe
Copy link
Contributor Author

gbe commented Oct 30, 2024

@qu35t-code Hopefully I understood what shell check complained about, and fixed it.

@qu35t-code
Copy link
Member

@gbe
Copy link
Contributor Author

gbe commented Nov 6, 2024

@qu35t-code Could you restart the pipeline to confirm that Exegol builds fine?

@qu35t-code
Copy link
Member

Done @gbe Thanks

@qu35t-code
Copy link
Member

@gbe can you fix shellcheck ? I will fix temp fix

@gbe
Copy link
Contributor Author

gbe commented Nov 7, 2024

@qu35t-code It's done. Can you run the check again please? Thanks

@qu35t-code qu35t-code added the ready for merge in the waitlist for merge, requires preliminary steps label Nov 8, 2024
@ShutdownRepo ShutdownRepo merged commit c2bd89e into ThePorgs:dev Nov 8, 2024
42 checks passed
@ShutdownRepo ShutdownRepo mentioned this pull request Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix It's a bird, it's a plane ready for merge in the waitlist for merge, requires preliminary steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants