Skip to content

Remove ConsoleProvider from main code #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

TheAngryByrd
Copy link
Owner

Proposed Changes

ConsoleProvider was a mock/example that shouldn't have been release in the main codebase. This moves it to the examples to show how you might implement a console logger if you so desire.

Types of changes

What types of changes does your code introduce to FsLibLog?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

ConsoleProvider was a mock/example that shouldn't have been release in the main codebase.  This moves it to the examples to show how you might implement a console logger if you so desire.
@TheAngryByrd TheAngryByrd requested a review from baronfel November 8, 2019 17:22
@baronfel
Copy link
Collaborator

baronfel commented Nov 8, 2019

This is probably ok. We don't want people relying on underpowered implementations anyway :)

@TheAngryByrd TheAngryByrd merged commit 06ee012 into master Nov 8, 2019
TheAngryByrd pushed a commit that referenced this pull request Nov 8, 2019
* BREAKING: Remove ConsoleProvider from main code (#10)
@TheAngryByrd TheAngryByrd deleted the remove-ConsoleProvider branch August 18, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants