Skip to content

Accept the new VisualType in Static and Label #5618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 12, 2025

Conversation

davidfokkema
Copy link
Contributor

@davidfokkema davidfokkema commented Mar 6, 2025

This change keeps mypy happy.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)

@davidfokkema
Copy link
Contributor Author

Thanks to @TomJGooding pointing out the solution to #5617.

Copy link
Collaborator

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is right.

That setter should probably be renamed to content. Since that's a breaking change, it probably makes sense to put it off until the next major release.

Would you mind adding a TODO for that in this PR?

@davidfokkema
Copy link
Contributor Author

I added TODO items for the Label parameter renderable and the setter on Static.

@willmcgugan willmcgugan merged commit 4bbee2f into Textualize:main Mar 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants