-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting a keymap doesn't update the Footer
or help panel
#5695
Comments
Footer
or help panelFooter
or help panel
Widgets cannot get automatic notification that the parent bindings change I believe. Try calling a manual refresh in action_change? |
@Forgen The fact that both the footer and the key panel subscribe to |
I thought in the Textual signal architecture that signals only bubble
upward?
…On Tue, Apr 1, 2025, 11:04 AM Dave Pearson ***@***.***> wrote:
@Forgen <https://github.com/Forgen> The fact that both the footer and the
key panel subscribe to bindings_updated_signal
<https://textual.textualize.io/api/screen/#textual.screen.Screen.bindings_updated_signal>
suggests that the intent is that that should not be necessary.
—
Reply to this email directly, view it on GitHub
<#5695 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFSM646LA6XUU76ULH6HGD2XK2IRAVCNFSM6AAAAAB2GYPVNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRZHA3DQOBTGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: davep]*davep* left a comment (Textualize/textual#5695)
<#5695 (comment)>
@Forgen <https://github.com/Forgen> The fact that both the footer and the
key panel subscribe to bindings_updated_signal
<https://textual.textualize.io/api/screen/#textual.screen.Screen.bindings_updated_signal>
suggests that the intent is that that should not be necessary.
—
Reply to this email directly, view it on GitHub
<#5695 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFSM646LA6XUU76ULH6HGD2XK2IRAVCNFSM6AAAAAB2GYPVNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRZHA3DQOBTGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@Forgen I suspect you're confusing signals and messages. Messages bubble, signals are pub/sub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Given this code:
Pressing f2 remaps the binding to f9 but the
Footer
and help panel both show the old mapping. If you pull up the command palette, or tab away from and back to the terminal window (actions that would cause a refresh) then they both catch up.The text was updated successfully, but these errors were encountered: