Enhance Python injection syntax via Issue #6 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there, thanks for the PR! Maybe a comparison screenshot (before and after) would help + the specific example of issue 6, that you say this fixes. Thank you in advance! |
|
No worries! My apologies for not making it more clear. Here's that same code block in #6 before and after for clarity since that was the focus. Before my changes: After my changes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the TextMate grammar patterns in
python.injection.jsonand adds some explicit checks for comment characters at the start of lines, which should fix #6.There's also some better handling of white-space around CSS string declarations
E.g.