Skip to content

Don't underline indentation #3678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 30, 2025
Merged

Don't underline indentation #3678

merged 4 commits into from
Mar 30, 2025

Conversation

willmcgugan
Copy link
Member

Prevent code highlights in exceptions from highlighting indentation. Previously indentation was underline, which didn't look good.
Screenshot 2025-03-29 at 15 55 15
Screenshot 2025-03-29 at 15 55 24

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 98.09%. Comparing base (225cb07) to head (47da97e).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
rich/traceback.py 56.00% 11 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3678      +/-   ##
==========================================
- Coverage   98.24%   98.09%   -0.16%     
==========================================
  Files          74       74              
  Lines        8105     8124      +19     
==========================================
+ Hits         7963     7969       +6     
- Misses        142      155      +13     
Flag Coverage Δ
unittests 98.09% <56.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@willmcgugan willmcgugan merged commit 39fa5ee into master Mar 30, 2025
21 checks passed
@willmcgugan willmcgugan deleted the exception-ranges branch March 30, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants