Skip to content

SVG export - Safari - Prevent box appearing on rounded corners #2201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2022

Conversation

darrenburns
Copy link
Member

@darrenburns darrenburns commented Apr 19, 2022

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Closes #2171

Uses box-shadow in place of outline, since Safari has buggy outline support. Note that this doesn't fix the issue with the rotated background panel not showing on Safari, but at least the output no longer looks broken.

Before

Screenshot 2022-04-19 at 17 31 10

After

Screenshot 2022-04-19 at 17 31 28

Example with light theme

Screenshot 2022-04-19 at 17 32 10

@darrenburns darrenburns marked this pull request as ready for review April 19, 2022 16:44
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.94%. Comparing base (46b1c95) to head (f7ea7ff).
Report is 1278 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2201      +/-   ##
==========================================
- Coverage   99.07%   98.94%   -0.13%     
==========================================
  Files          72       73       +1     
  Lines        7555     7606      +51     
==========================================
+ Hits         7485     7526      +41     
- Misses         70       80      +10     
Flag Coverage Δ
unittests 98.94% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@olivierphi olivierphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👌

@willmcgugan
Copy link
Member

What an awful hack. Good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] SVG gets surrounded in a black box
4 participants