Skip to content

fix(space): fix fragment virtual node has not been expanded #5388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 12, 2025
Merged

fix(space): fix fragment virtual node has not been expanded #5388

merged 12 commits into from
May 12, 2025

Conversation

QuentinHsu
Copy link
Collaborator

@QuentinHsu QuentinHsu commented Apr 28, 2025 •
edited by Wesley-0808
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#5352
#5296

💡 需求背景和解决方案

递归地将所有嵌套 Fragment 虚拟节点展开为一维数组，并且会跳过 Comment 节点。

📝 更新日志

tdesign-vue-next

  • fix(Space): 修复fragment虚拟节点未展开的问题

  • fix(Space): 修复teleport结构意外渲染为SpaceItem节点，导致额外占用间距的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@tdesign-bot
Copy link
Collaborator

tdesign-bot commented Apr 28, 2025 •
edited
Loading

TDesign Component Site Preview Open

Component Preview
tdesign-vue-next 完成
@tdesign-vue-next/chat 完成

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 28, 2025 •
edited
Loading

tdesign-vue-next-demo

npm i https://pkg.pr.new/tdesign-vue-next@5388

commit: 543994a

@QuentinHsu QuentinHsu force-pushed the feature/slot-flat-children branch from 4f2ffd8 to d5ac57a Compare April 28, 2025 16:11
@Wesley-0808
Copy link
Collaborator

可以的话，带着处理一下 #5296 咯？

@QuentinHsu
Copy link
Collaborator Author

可以的话，带着处理一下 #5296 咯？

好的，我晚点看看

@Wesley-0808
Copy link
Collaborator

/update-snapshot

@github-actions GitHub Actions
Copy link
Contributor

⏳ 正在运行快照更新。。。 CI: Open

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

⏳ 正在运行快照更新。。。 CI: Open

@Wesley-0808
Copy link
Collaborator

Wesley-0808 commented Apr 29, 2025 •
edited
Loading

oops...
快照出现了不符合预期的变更，逻辑处理或许有点问题。（看上面更新快照的commit，空的spaceItem节点）

@QuentinHsu
Copy link
Collaborator Author

oops... 快照出现了不符合预期的变更，逻辑处理或许有点问题。（看上面更新快照的commit，空的spaceItem节点）

好的，我本地看看

@QuentinHsu QuentinHsu force-pushed the feature/slot-flat-children branch from 5558f47 to 922ac01 Compare April 30, 2025 07:29
@QuentinHsu
Copy link
Collaborator Author

oops... 快照出现了不符合预期的变更，逻辑处理或许有点问题。（看上面更新快照的commit，空的spaceItem节点）

已修复意外出现的空 t-space-item 问题

Wesley-0808
Wesley-0808 reviewed Apr 30, 2025
View reviewed changes
@Wesley-0808
Copy link
Collaborator

🌹
等uy CR 👀

@tdesign-bot
Copy link
Collaborator

tdesign-bot commented May 7, 2025 •
edited by Wesley-0808
Loading

📝 更新日志

tdesign-vue-next

  • fix(Space): 修复fragment虚拟节点未展开的问题
  • fix(Space): 修复teleport结构意外渲染为SpaceItem节点，导致额外占用间距的问题

@uyarn uyarn closed this May 7, 2025
@uyarn uyarn reopened this May 7, 2025
@uyarn uyarn merged commit 38f3d86 into Tencent:develop May 12, 2025
1 check passed
@Wesley-0808 Wesley-0808 mentioned this pull request May 14, 2025
Merged
16 tasks
@tdesign-bot tdesign-bot mentioned this pull request May 14, 2025
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uyarn uyarn uyarn approved these changes

@Wesley-0808 Wesley-0808 Wesley-0808 approved these changes

@PengYYYYY PengYYYYY Awaiting requested review from PengYYYYY PengYYYYY is a code owner

@chaishi chaishi Awaiting requested review from chaishi chaishi is a code owner

@zhangpaopao0609 zhangpaopao0609 Awaiting requested review from zhangpaopao0609 zhangpaopao0609 is a code owner

@liweijie0812 liweijie0812 Awaiting requested review from liweijie0812 liweijie0812 is a code owner

@Cat1007 Cat1007 Awaiting requested review from Cat1007 Cat1007 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QuentinHsu @tdesign-bot @Wesley-0808 @uyarn