Skip to content

fix(tag-input): 修复 useTagList 中 tagValue 的空值逻辑 #5357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

yuhengshen
Copy link
Contributor

@yuhengshen yuhengshen commented Apr 24, 2025

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

当设置了value,且value为 undefined 时(或者值被外部重置为 undefined ),tag-input 相关逻辑判空不全面,导致组件初始化失败。

📝 更新日志

  • fix(TagInput): 优化 TagInput 处理空值的逻辑

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@uyarn
Copy link
Collaborator

uyarn commented Apr 24, 2025

多选(taginput) 的场景 主动设置了个undefined的值?

@tdesign-bot
Copy link
Collaborator

TDesign Component Site Preview Open

Component Preview
tdesign-vue-next 完成
@tdesign-vue-next/chat 完成

Copy link

pkg-pr-new bot commented Apr 24, 2025

Open in StackBlitz

npm i https://pkg.pr.new/tdesign-vue-next@5357

commit: 2f8454f

@yuhengshen
Copy link
Contributor Author

yuhengshen commented Apr 24, 2025

表单场景下,假如这个多选值没有勾选(或者多选框是条件渲染的),设置成undefined也是很常见(避免传递给后端,没有设置和设置成空可能是两个语意。),另外快捷重置数据也可能整个对象设置成空。原代码中也有部分处理了空值,例如newLabel?.map?.

@uyarn
Copy link
Collaborator

uyarn commented Apr 24, 2025

表单场景下,假如这个多选值没有勾选(或者多选框是条件渲染的),设置成undefined也是很常见(避免传递给后端,没有设置和设置成空可能是两个语意。),另外快捷重置数据也可能整个对象设置成空。原代码中也有部分处理了空值,例如newLabel?.map?.

了解了,确实需要兜底,或者是一些动态表单可能很难约束 我们今天发了这个版本后合入 目前可以先用 npm i https://pkg.pr.new/tdesign-vue-next@5357

ngyyuusora

This comment was marked as resolved.

@uyarn uyarn merged commit 3a8cf4d into Tencent:develop Apr 28, 2025
10 checks passed
@liweijie0812 liweijie0812 mentioned this pull request May 9, 2025
16 tasks
@tdesign-bot tdesign-bot mentioned this pull request May 14, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants