Skip to content

feat(DatePicker): support readonly props #5293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2025
Merged

feat(DatePicker): support readonly props #5293

merged 1 commit into from
Apr 11, 2025

Conversation

mikasayw
Copy link
Contributor

@mikasayw mikasayw commented Apr 10, 2025 •
edited by Wesley-0808
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

  • image
  • 在 DatePicker.tsx 文件中已实现，问题出在没有接收 props
  • 增加 props type docs 等即可

📝 更新日志

  • feat(datePicker): 新增readOnly属性，用于只读配置

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@tdesign-bot
Copy link
Collaborator

TDesign Component Site Preview Open

Component Preview
tdesign-vue-next 完成
@tdesign-vue-next/chat 完成

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 10, 2025

Open in StackBlitz

npm i https://pkg.pr.new/tdesign-vue-next@5293

commit: 7663e04

@uyarn uyarn merged commit 522bc63 into Tencent:develop Apr 11, 2025
10 checks passed
@liweijie0812
Copy link
Collaborator

跟 form readonly 优先级有问题 ，DatePicker readonly 默认值需要改为 undefined，

@mikasayw mikasayw mentioned this pull request Apr 11, 2025
Merged
@uyarn
Copy link
Collaborator

uyarn commented Apr 11, 2025

跟 form readonly 优先级有问题 ，DatePicker readonly 默认值需要改为 undefined，

噢 遗漏了这个逻辑

@mikasayw mikasayw mentioned this pull request Apr 11, 2025
Merged
16 tasks
@Wesley-0808 Wesley-0808 mentioned this pull request Apr 12, 2025
Closed
mikasayw added a commit to mikasayw/tdesign-vue-next that referenced this pull request Apr 14, 2025
@mikasayw
Merge branch 'develop' into fix_input_number
75aa852 
* develop:
  feat(DatePicker): fix readonly default value (Tencent#5295)
  feat(DatePicker): support readonly props (Tencent#5293)
  TD Mono:  refactoring the vue-next test (Tencent#5263)
  docs(config-provider): sync api (Tencent#5159)
@uyarn uyarn mentioned this pull request Apr 14, 2025
Open
16 tasks
@github-actions github-actions bot mentioned this pull request Apr 24, 2025
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uyarn uyarn uyarn approved these changes

@PengYYYYY PengYYYYY Awaiting requested review from PengYYYYY PengYYYYY is a code owner

@chaishi chaishi Awaiting requested review from chaishi chaishi is a code owner

@zhangpaopao0609 zhangpaopao0609 Awaiting requested review from zhangpaopao0609 zhangpaopao0609 is a code owner

@liweijie0812 liweijie0812 Awaiting requested review from liweijie0812 liweijie0812 is a code owner

@Cat1007 Cat1007 Awaiting requested review from Cat1007 Cat1007 is a code owner

@Wesley-0808 Wesley-0808 Awaiting requested review from Wesley-0808 Wesley-0808 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikasayw @tdesign-bot @liweijie0812 @uyarn