Skip to content

feat(colorPicker): add Clear Event #5109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 26, 2025

Conversation

mikasayw
Copy link
Contributor

@mikasayw mikasayw commented Feb 27, 2025

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat(colorPicker): 新增onClear清除按钮事件回调

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Feb 27, 2025

完成

@Wesley-0808
Copy link
Collaborator

Wesley-0808 commented Feb 28, 2025

需要在api平台生成一下类型和文档

@mikasayw
Copy link
Contributor Author

需要在api平台生成一下类型和文档

TDesignOteam/tdesign-api#561
api 平台已经提交了类型和文档的 pr,下一步该如何做呢?

@Wesley-0808
Copy link
Collaborator

Wesley-0808 commented Feb 28, 2025

需要在api平台生成一下类型和文档

TDesignOteam/tdesign-api#561

api 平台已经提交了类型和文档的 pr,下一步该如何做呢?

你本地跑了api平台,在api平台上操作生成文件生成colorPicker组件的文件,选中输出文件到各框架仓库进行导出

https://github.com/TDesignOteam/tdesign-api/blob/main/README.md 中生成API的部分

注意需要再看看md文件和type文件有没有不是你在api平台修改的内容 只推送你修改的内容就好

@Wesley-0808
Copy link
Collaborator

api那边可以把vue和react框架都选上 这个回调应该都要做的

@Wesley-0808 Wesley-0808 changed the title feat(color-picker): add vue-next color-picker clear event feat(colorPicker): add Clear Event Feb 28, 2025
@mikasayw
Copy link
Contributor Author

嗯 明白了
react 仓库的功能和api 平台的文档看起来不同步,可能需要单独去提交

@Wesley-0808
Copy link
Collaborator

Wesley-0808 commented Feb 28, 2025

react 仓库的功能和api 平台的文档看起来不同步,可能需要单独去提交

@mikasayw 那你就先做了这个栈的吧,等api那边merge了 我再看看那边的

@uyarn
Copy link
Collaborator

uyarn commented Mar 25, 2025

处理下冲突就可以合并这个PR

@Wesley-0808
Copy link
Collaborator

处理下冲突就可以合并这个PR

还有文档和类型没生成

@Wesley-0808
Copy link
Collaborator

@mikasayw 文档那些帮你整了,冲突自行处理下 🌹

* develop: (46 commits)
  refactor(upload): components optimization (Tencent#5205)
  chore: fix treeselect props missing (Tencent#5220)
  chore: add preinstall script to skip init submodule in common repo(Tencent#5214)
  docs(card): fix card api documentation text (Tencent#5209)
  feat(Icon): upgrade tdesign-icons-vue-next to 0.3.5 (Tencent#5213)
  ci: up pnpm to 9.15.9 (Tencent#5211)
  refactor(bundle): builds components (Tencent#5192)
  fix(menu): fix missing string type of menu-item props to (Tencent#5198)
  chore: add default issue labels  (Tencent#5190)
  chore: release tdesign-vue-next 1.11.4 (Tencent#5189)
  fix(button): add class when the shape props is rectangle (Tencent#5187)
  fix(Descriptions): fix helper (Tencent#5182)
  chore: release tdesign-vue-next  1.11.3 (Tencent#5180)
  chore: fix warning and update common (Tencent#5179)
  fix(Select): select all error when `valueType = 'object'` (Tencent#5167)
  fix(ColorPicker): colorPicker Input register onChange event (Tencent#5111)
  refactor(DatePicker): `useDisableDate` to use common `isEnabledDate` (Tencent#5119)
  fix(Select): unnecessary `filterable` when `filter` (Tencent#5169)
  fix: fix build vue-next types (Tencent#5174)
  chore(deps):  update deps (Tencent#5162)
  ...
@mikasayw
Copy link
Contributor Author

@uyarn @Wesley-0808 conflict resolved

@uyarn
Copy link
Collaborator

uyarn commented Mar 26, 2025

/update-common

Copy link

pkg-pr-new bot commented Mar 26, 2025

Open in Stackblitz

npm i https://pkg.pr.new/tdesign-vue-next@5109

commit: 7996377

@uyarn uyarn merged commit d90fae6 into Tencent:develop Mar 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants