-
Notifications
You must be signed in to change notification settings - Fork 345
feat(tree): support function callback usage for checkProps #3501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
uyarn
merged 4 commits into
Tencent:develop
from
phalera:feature/tree-checkProps-function
Apr 14, 2025
Merged
feat(tree): support function callback usage for checkProps #3501
uyarn
merged 4 commits into
Tencent:develop
from
phalera:feature/tree-checkProps-function
Apr 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
RylanBot
approved these changes
Apr 11, 2025
c9c0c05
to
53de661
Compare
HaixingOoO
approved these changes
Apr 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
packages/components/tree/TreeItem.tsx:259
- If checkProps is undefined, spreading it into the Checkbox component may cause a runtime error. Consider defaulting to an empty object by changing the line to 'checkboxProps = checkProps || {};' to ensure safe spreading.
checkboxProps = checkProps;
uyarn
reviewed
Apr 14, 2025
uyarn
approved these changes
Apr 14, 2025
Merged
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
feat(tree): checkProps参数支持函数传入,支持不同节点设置不同checkProps
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单