fix(color-picker): ensure color change is emitted with updated mode #3493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RylanBot
requested review from
honkinglin,
uyarn,
carolin913,
HaixingOoO,
NWYLZW and
ZWkang
as code owners
commit: |
|
|
RylanBot
force-pushed
the
fix/color-picker
branch
from
aad4a5f to
f0ec415
Compare
RylanBot
force-pushed
the
fix/color-picker
branch
from
f0ec415 to
71a8665
Compare
HaixingOoO
approved these changes
Apr 10, 2025
uyarn
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
Jietu20250408-204026-HD.mp4
具体问题
颜色模式切换的时候，必须再手动点击下面的色板，input 框才会更新色值。
产生原因
handleModeChange中没有调用emitColorChange方法handleModeChange->setMode->emitColorChange->formatValue获取的mode是异步更新前的旧值（Test 中的验证 ColorMode 缓存不太合理，这个场景下，切换后再切回来，颜色必然变化）
📝 更新日志
fix(color-picker): ensure color change is emitted with updated mode
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单