Skip to content

feat(config-provider): support global-config affect plugin usage #3488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 9, 2025

Conversation

lifeiFront
Copy link
Collaborator

@lifeiFront lifeiFront commented Apr 7, 2025

新增全局配置属性,message,loading组件支持全局属性配置

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat(config-provider): 新增全局配置属性,message,loading组件支持全局属性配置

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

…支持全局属性配置

新增全局配置属性,message组件支持全局属性配置
Copy link
Contributor

github-actions bot commented Apr 7, 2025

完成

…性,message组件支持全局属性配置

新增全局配置属性,message组件支持全局属性配置
Copy link

pkg-pr-new bot commented Apr 7, 2025

Open in StackBlitz

npm i https://pkg.pr.new/tdesign-react@3488

commit: 39ea603

@uyarn uyarn changed the title feat(config-provider): 新增全局配置属性,message组件… feat(config-provider): support global-config affect plugin usage Apr 8, 2025
新增全局配置属性
新增全局配置属性
新增全局配置属性
@uyarn uyarn requested a review from Copilot April 8, 2025 09:16
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

packages/components/config-provider/ConfigProvider.tsx:28

  • The top-level variable 'globalConfig' is shadowing the prop 'globalConfig' in the ConfigProvider component, which can lead to confusion. Consider renaming the top-level variable (e.g., to 'globalConfigStore') to differentiate it from the component prop.
let globalConfig = defaultGlobalConfig;

@uyarn uyarn merged commit 42ab2bb into Tencent:develop Apr 9, 2025
9 checks passed
@github-actions github-actions bot mentioned this pull request Apr 11, 2025
16 tasks
@uyarn uyarn mentioned this pull request Apr 18, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants