Skip to content

feat(drawer): add DrawerPlugin #3381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 16, 2025
Merged

Conversation

Wesley-0808
Copy link
Contributor

@Wesley-0808 Wesley-0808 commented Feb 24, 2025

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat(Drawer): 新增DrawerPlugin,支持函数式调用,具体使用请参考示例

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Feb 24, 2025

完成

@Wesley-0808 Wesley-0808 changed the title feat: DrawerPlugin feat(drawer): add DrawerPlugin Feb 26, 2025
commit dd4c832
Author: wū yāng <[email protected]>
Date:   Sun Mar 2 15:19:16 2025 +0800

    chore: change docs file path (Tencent#3403)

commit 071c4b8
Author: wū yāng <[email protected]>
Date:   Sun Mar 2 15:04:50 2025 +0800

    refactor: mono repo move src to packages/components (Tencent#3402)

    * chore: remove old submodule

    * refactor: add new submodule

    * refactor: add new submodule

    * refactore: move src to packages/components

    * refactor: mono repo

    * refactor: site rerun

    * refactor: test rerun

    * refactor: fix build

commit 9a0b6ac
Author: Haixing <[email protected]>
Date:   Fri Feb 28 16:59:07 2025 +0800

    Release: 1.11.1 (Tencent#3393)

    * release/1.11.1

    * chore: changelog's changes

    ---------

    Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

commit bfc06a6
Author: wū yāng <[email protected]>
Date:   Fri Feb 28 16:25:28 2025 +0800

    fix: fix cjs bundle (Tencent#3392)

commit b15b142
Author: liweijie0812 <[email protected]>
Date:   Wed Feb 26 16:21:35 2025 +0800

    feat(Content): support content api (Tencent#3384)

commit 0cc866b
Author: huangchen1031 <[email protected]>
Date:   Wed Feb 26 16:21:12 2025 +0800

    fix(Table): fix footer render when using virtual scroll (Tencent#3383)

    * fix(table): 修复虚拟滚动下的footer渲染问题

    * chore: update snapshots

    * chore: update snapshots

    * chore: update snapshot

    ---------

    Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merge branch 'develop' into feat/drawerPlugin
Copy link

pkg-pr-new bot commented Apr 14, 2025

Open in StackBlitz

npm i https://pkg.pr.new/tdesign-react@3381

commit: c2208e8

@HaixingOoO HaixingOoO requested a review from Copilot April 15, 2025 01:23
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • test/snap/snapshots/csr.test.jsx.snap: Language not supported
  • test/snap/snapshots/ssr.test.jsx.snap: Language not supported
Comments suppressed due to low confidence (1)

packages/components/drawer/Drawer.tsx:115

  • In the useEffect block, merging props into state for non-plugin usage may unintentionally override imperative updates made via the DrawerInstance (e.g., from the update method). Consider adding a conditional check (such as shallow equality) to prevent unnecessary state overrides and re-renders.
if (!isPlugin) { setState((prevState) => ({ ...prevState, ...props })); }

@uyarn uyarn merged commit 9c90f40 into Tencent:develop Apr 16, 2025
9 checks passed
@github-actions github-actions bot mentioned this pull request Apr 18, 2025
16 tasks
@Wesley-0808 Wesley-0808 deleted the feat/drawerPlugin branch May 21, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants