-
Notifications
You must be signed in to change notification settings - Fork 345
feat(drawer): add DrawerPlugin #3381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 24, 2025
commit dd4c832 Author: wū yāng <[email protected]> Date: Sun Mar 2 15:19:16 2025 +0800 chore: change docs file path (Tencent#3403) commit 071c4b8 Author: wū yāng <[email protected]> Date: Sun Mar 2 15:04:50 2025 +0800 refactor: mono repo move src to packages/components (Tencent#3402) * chore: remove old submodule * refactor: add new submodule * refactor: add new submodule * refactore: move src to packages/components * refactor: mono repo * refactor: site rerun * refactor: test rerun * refactor: fix build commit 9a0b6ac Author: Haixing <[email protected]> Date: Fri Feb 28 16:59:07 2025 +0800 Release: 1.11.1 (Tencent#3393) * release/1.11.1 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit bfc06a6 Author: wū yāng <[email protected]> Date: Fri Feb 28 16:25:28 2025 +0800 fix: fix cjs bundle (Tencent#3392) commit b15b142 Author: liweijie0812 <[email protected]> Date: Wed Feb 26 16:21:35 2025 +0800 feat(Content): support content api (Tencent#3384) commit 0cc866b Author: huangchen1031 <[email protected]> Date: Wed Feb 26 16:21:12 2025 +0800 fix(Table): fix footer render when using virtual scroll (Tencent#3383) * fix(table): 修复虚拟滚动下的footer渲染问题 * chore: update snapshots * chore: update snapshots * chore: update snapshot --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Merge branch 'develop' into feat/drawerPlugin
uyarn
reviewed
Apr 14, 2025
uyarn
reviewed
Apr 14, 2025
uyarn
reviewed
Apr 14, 2025
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (2)
- test/snap/snapshots/csr.test.jsx.snap: Language not supported
- test/snap/snapshots/ssr.test.jsx.snap: Language not supported
Comments suppressed due to low confidence (1)
packages/components/drawer/Drawer.tsx:115
- In the useEffect block, merging props into state for non-plugin usage may unintentionally override imperative updates made via the DrawerInstance (e.g., from the update method). Consider adding a conditional check (such as shallow equality) to prevent unnecessary state overrides and re-renders.
if (!isPlugin) { setState((prevState) => ({ ...prevState, ...props })); }
HaixingOoO
reviewed
Apr 15, 2025
uyarn
reviewed
Apr 15, 2025
HaixingOoO
approved these changes
Apr 15, 2025
uyarn
approved these changes
Apr 16, 2025
16 tasks
Merged
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
Vue2: feat(drawer): add DrawerPlugin tdesign-vue#3501
VueNext: feat(drawer): add DrawerPlugin tdesign-vue-next#5067
📝 更新日志
feat(Drawer): 新增
DrawerPlugin
,支持函数式
调用,具体使用请参考示例本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单