CustomNPCs mod crashes GC 283 during game launch

[EzerArch]

Forge Version

14.23.5.2860

Galacticraft Version

4.0.2.283

Log or Crash Report

https://gist.github.com/EzerArch/a873268c761a310ef12aca9e19ad8f37

Reproduction steps

GC 283 will crash with CustomNPCs 1.12.2 during launch, while GC 280 didn't. Probably GC inventory is conflicting with CustomNPCs'.

With a fresh instance, start the game with these mods in mod folder:

• CustomNPCs_1.12.2-(05Jul20).jar
• Galacticraft-1.12.2-4.0.2.283.jar
• OptiFine_1.12.2_HD_U_G5.jar (optional, it doesn't change the result)

The launch will break at "Loading - Constructing mods" with:

The game crashed whilst initializing game
Error: java.lang.NoClassDefFoundError: micdoodle8/mods/galacticraft/api/client/tabs/InventoryTabFactions
Exit Code: -1

[craftablescience]

@MJRLegends rom went to a lot of trouble to ensure compatibility, sorry you feel differently
anyway this isn't entirely relevant to the issue

[ROMVoid95]

@MJRLegends what was released has zero, and I do mean zero, breaking changes nor major changes that wouldn't be considered breaking.

@EzerArch thanks for this, I'll get the fix uploaded tonight.

[MJRLegends]

You're correct i would like to apologise for my previous message :)

Also has to be said, Thanks for your hard work ROM on the merged version 👍 and making sure everything wasn't broken.

I care alot for Galacticraft 😄

[ROMVoid95]

No worries/animosity here 👍

[EzerArch]

@EzerArch thanks for this, I'll get the fix uploaded tonight.

Thank you @ROMVoid95 . :)

[ROMVoid95]

So the cause for this crash is a tad tricky. The root cause is due to CustomNPC's containing classes in micdoodle8.mods.galacticraft.api.client.tabs. Since the new release is signed these conflict with the classes in the package under CustomNPC's jar.

[ROMVoid95]

In the end the quickest fix is to just remove jar signing and fingerprints. Going through the issue reporting process for CustomNPC's and having to wait on an update (if they would) isn't at the moment a priority for the sake of having GC signed.