Skip to content

Enable working day calculation instead of working time calculation #2347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arolfes opened this issue Jul 31, 2023 · 2 comments · Fixed by #2342
Closed

Enable working day calculation instead of working time calculation #2347

arolfes opened this issue Jul 31, 2023 · 2 comments · Fixed by #2342
Labels
bug enhancement
Milestone
v7.0.0

Comments

@arolfes
Copy link
Contributor

arolfes commented Jul 31, 2023

Our customer wants the old behaviour to calculate the dueDate from before version 6.0.0 back

Example:
actual:
ServiceLevel=3 Tage
PlanedDate=30.07.2023 (Sunday) -> 31.07.2023 (Monday)
DueDate=02.08.2023 (Wednesday)

expected:
ServiceLevel=3 Tage
PlanedDate=30.07.2023 (Sunday) -> 31.07.2023 (Monday)
DueDate=03.08.2023 (Thursday)

affected Version 6.0.2 and following
@arolfes
Copy link
Contributor Author

arolfes commented Jul 31, 2023

To fulfil the needs of other customers we decided to make the behaviour configurable.

You can decide if you want to have precise WorkingTime calculation based on milliseconds or if you want the calculation based on the Day.

@arolfes
Copy link
Contributor Author

arolfes commented Jul 31, 2023

New configuarion property

taskana.workingTime.useWorkingTimeCalculation=true

default value true

When this property is set to true, the Working*Time*CalculatorImpl is used.
When this property is false, the Working*Day*CalculatorImpl is used.

The WorkingDayCalculator is a new class and implements the interface WorkingTimeCalculator

We also implement at least the following 3 testcases:

Beispiel 1:
ServiceLevel=3 Days
PlanedDate=30.07.2023 (Sunday) -> 31.07.2023 (Monday)
DueDate=03.08.2023 (Thursday)

Beispiel 2:
ServiceLevel=2 Tage
PlanedDate=29.03.2024 (Good Friday) -> 02.04.2024 (Tuesday)
DueDate=04.04.2024 (Thursday)

Beispiel 3:
ServiceLevel=13 Tage
PlanedDate=29.03.2024 (Good Friday) -> 02.04.2024 (Tuesday)
DueDate=19.04.2024 (Friday one week later)

@arolfes arolfes linked a pull request Jul 31, 2023 that will close this issue
Configuration to enable working day calculation instead of working time calculation #2342
Merged
14 tasks
arolfes added a commit that referenced this issue Aug 1, 2023
@mustaphazorgati @arolfes
Closes #2347: Configuration to enable working day calculation instead…
f287054 
… of working time calculation

Closes #2347: Configuration to enable working day calculation instead of working time calculation

* added configuration property for detailed working time calculation
* added WorkingDayCalculatorImpl to replicate pre 6.0.0 behaviour
* bugfix ServiceLevelHandler comparing classificationKeys

---------

Co-authored-by: arolfes <[email protected]>
@arolfes arolfes closed this as completed Aug 1, 2023
arolfes added a commit to arolfes/taskana that referenced this issue Aug 1, 2023
@mustaphazorgati @arolfes
Closes Taskana#2347: Configuration to enable working day calculation …
f91efde 
…instead of working time calculation

Closes Taskana#2347: Configuration to enable working day calculation instead of working time calculation

* added configuration property for detailed working time calculation
* added WorkingDayCalculatorImpl to replicate pre 6.0.0 behaviour
* bugfix ServiceLevelHandler comparing classificationKeys

---------

Co-authored-by: arolfes <[email protected]>
arolfes added a commit that referenced this issue Aug 1, 2023
@mustaphazorgati @arolfes
Closes #2347: Configuration to enable working day calculation instead…
8dacc28 
… of working time calculation

Closes #2347: Configuration to enable working day calculation instead of working time calculation

* added configuration property for detailed working time calculation
* added WorkingDayCalculatorImpl to replicate pre 6.0.0 behaviour
* bugfix ServiceLevelHandler comparing classificationKeys

---------

Co-authored-by: arolfes <[email protected]>
arolfes added a commit to arolfes/taskana that referenced this issue Aug 1, 2023
@mustaphazorgati @arolfes
Closes Taskana#2347: Configuration to enable working day calculation …
c1ffd99 
…instead of working time calculation

* added configuration property for detailed working time calculation
* added WorkingDayCalculatorImpl to replicate pre 6.0.0 behaviour
* bugfix ServiceLevelHandler comparing classificationKeys

---------

Co-authored-by: arolfes <[email protected]>
arolfes added a commit that referenced this issue Aug 1, 2023
@mustaphazorgati @arolfes
Closes #2347: Configuration to enable working day calculation instead…
3ec1544 
… of working time calculation

* added configuration property for detailed working time calculation
* added WorkingDayCalculatorImpl to replicate pre 6.0.0 behaviour
* bugfix ServiceLevelHandler comparing classificationKeys

---------

Co-authored-by: arolfes <[email protected]>
arolfes added a commit to arolfes/taskana that referenced this issue Aug 1, 2023
@mustaphazorgati @arolfes
Closes Taskana#2347: Configuration to enable working day calculation …
d3e6a76 
…instead of working time calculation

* added configuration property for detailed working time calculation
* added WorkingDayCalculatorImpl to replicate pre 6.0.0 behaviour
* bugfix ServiceLevelHandler comparing classificationKeys

---------

Co-authored-by: arolfes <[email protected]>
arolfes added a commit to arolfes/taskana that referenced this issue Aug 1, 2023
@mustaphazorgati @arolfes
Closes Taskana#2347: Configuration to enable working day calculation …
f280a79 
…instead of working time calculation

* added configuration property for detailed working time calculation
* added WorkingDayCalculatorImpl to replicate pre 6.0.0 behaviour
* bugfix ServiceLevelHandler comparing classificationKeys

---------

Co-authored-by: arolfes <[email protected]>
arolfes added a commit to arolfes/taskana that referenced this issue Aug 1, 2023
@mustaphazorgati @arolfes
Closes Taskana#2347: Configuration to enable working day calculation …
58d1977 
…instead of working time calculation

* added configuration property for detailed working time calculation
* added WorkingDayCalculatorImpl to replicate pre 6.0.0 behaviour
* bugfix ServiceLevelHandler comparing classificationKeys

---------

Co-authored-by: arolfes <[email protected]>
arolfes added a commit that referenced this issue Aug 1, 2023
@mustaphazorgati @arolfes
Closes #2347: Configuration to enable working day calculation instead…
0ffa2f0 
… of working time calculation

* added configuration property for detailed working time calculation
* added WorkingDayCalculatorImpl to replicate pre 6.0.0 behaviour
* bugfix ServiceLevelHandler comparing classificationKeys

---------

Co-authored-by: arolfes <[email protected]>
arolfes added a commit that referenced this issue Aug 1, 2023
@mustaphazorgati @arolfes
Closes #2347: Configuration to enable working day calculation instead…
fbd388e 
… of working time calculation

* added configuration property for detailed working time calculation
* added WorkingDayCalculatorImpl to replicate pre 6.0.0 behaviour
* bugfix ServiceLevelHandler comparing classificationKeys

---------

Co-authored-by: arolfes <[email protected]>
@ryzheboka ryzheboka moved this from Todo to Integrated in TASKANA Kanban Board Sep 29, 2023
@gitgoodjhe gitgoodjhe moved this from Integrated to In Progress in TASKANA Kanban Board Sep 29, 2023
@gitgoodjhe gitgoodjhe moved this from In Progress to Review in TASKANA Kanban Board Sep 29, 2023
@gitgoodjhe gitgoodjhe moved this from Review to Integrated in TASKANA Kanban Board Sep 29, 2023
@gitgoodjhe gitgoodjhe added this to the v7.0.0 milestone Sep 29, 2023
@gitgoodjhe gitgoodjhe moved this from Integrated to Released in TASKANA Kanban Board Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
TASKANA Kanban Board
Archived in project
Milestone
v7.0.0
2 participants
@arolfes @gitgoodjhe