Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/tool calling #81

Merged
merged 9 commits into from
Jan 17, 2025
Merged

Feature/tool calling #81

merged 9 commits into from
Jan 17, 2025

Conversation

jurmy24
Copy link
Member

@jurmy24 jurmy24 commented Jan 16, 2025

Closes #48, closes #63, and closes #78

This PR:

  • fixes the tool misformatting bug for tool calls (both JSON and XML misformatting) using a catch function in llm_service.py (started by @wjunwei2001 )
  • improves error communication between tools and the LLM (seen in the tools main.py functions)
  • improves the user notifications when a tool has been called (ensures only one is displayed per tool-type)
  • fixes the multiple tool calling errors (simply an indenting issue)
  • implements metadata filtering on classes using the chatbot intelligence by injecting class id information in the tools_metadata in registry.py

@wjunwei2001 please try it out and let me know what you think.

wangjunwei321 and others added 9 commits January 4, 2025 22:48
@wangjunwei321
Attempted to fix llama tool calling bug. General logic is in but stil…
d7cd2e0 
…l yet to be resolved as there are too many ways to hallucinate
@wangjunwei321 @wjunwei2001
Attempted to fix llama tool calling bug. General logic is in but stil…
615c917 
…l yet to be resolved as there are too many ways to hallucinate
@wjunwei2001
Merge branch 'feature/tool-calling' of https://github.com/Tanzania-AI…
adb7159 
…-Community/twiga into feature/tool-calling
@jurmy24
fix: solve malformed tool calls (Both XML and JSON)
b74df7e 
This should resolve issues #63 and #48
@jurmy24
feat: modify system prompt with clearer instructions
d00cc6b
@jurmy24
misc: remove a useless debug command
7ca69fc
@jurmy24
feat: make tool call notifications unitary and more consistent
912ef0d
@jurmy24
fix: improve tool error communication to the chatbot
fb0012b
@jurmy24
feat: implement metadata filtering (by class) in tool calls
c8ac324 
This should solve issue #56
@jurmy24 jurmy24 added this to the Release v0.1.0 milestone Jan 16, 2025
@jurmy24 jurmy24 requested a review from wjunwei2001 January 16, 2025 20:26
@jurmy24 jurmy24 linked an issue Jan 16, 2025 that may be closed by this pull request
[Feature]: Make multiple tool calls at once (eg. if user asks for multiple searches or multiple exercises) #48
Closed
@jurmy24 jurmy24 changed the base branch from main to development January 16, 2025 20:26
wjunwei2001
wjunwei2001 approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@wjunwei2001 wjunwei2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Tool calling error is resolved when tested. Tested for singular and multiple tool call whatsapp request

@jurmy24 jurmy24 merged commit c2040e0 into development Jan 17, 2025
4 checks passed
@jurmy24 jurmy24 deleted the feature/tool-calling branch January 17, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjunwei2001 wjunwei2001 wjunwei2001 approved these changes

Assignees

@wjunwei2001 wjunwei2001

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jurmy24 @wjunwei2001 @wangjunwei321