Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jurmy24/development/flow review #61

Merged
merged 31 commits into from
Dec 3, 2024
Merged

Jurmy24/development/flow review #61

merged 31 commits into from
Dec 3, 2024

Conversation

jurmy24
Copy link
Member

@jurmy24 jurmy24 commented Nov 28, 2024

Did a complete review of @fredygerman 's flow code with a bit of refactoring and readability improvements.

jurmy24 added 29 commits November 22, 2024 22:16
@jurmy24
doc: add table plus recommendation
4a36a16
@jurmy24
Db: add function to get class id's and assign teacher to classes
c3ea4b1
@jurmy24
Fix: update the name to lowercase
8bb9dfc
@jurmy24
Refactor: move the handle_new_dummy method to the messaging_service s…
3e6a2b8 
…ince it makes more sense there.
@jurmy24
Refactor: messaging service is now request service
0cf688f
@jurmy24
Feat: state service handles active user state too
117a153
@jurmy24
Refactor: messaging service -> request service
53302dd
@jurmy24
Feat: add the flows strings
4fc2774
@jurmy24
Refactor: move the flows webhook to request_service
959e512
@jurmy24
Misc: remove unused functions
70ff502
@jurmy24
Fix: remove selected_class_ids
b650b97
@jurmy24
Style: clean the code of sending flows and make it more concise
2f9461d
@jurmy24
Refactor: rename to flow_utils
56bdc8d
@jurmy24
Style: make onboarding service more concise
1e57e5a
@jurmy24
Feat: add flows strings
be9308f
@jurmy24
Db (WIP): start using my enums as return values instead of the strings
24da1a2
@jurmy24
Misc: add input value to the classes_flow_header and body
654302b
@jurmy24
Feat: add emoji map to the subject names and a display property
8b2af6f
@jurmy24
Refactor: move messaging related methods to messaging service
c5c59c5
@jurmy24
Refactor: move messaging service related methods to messaging_service
69ad5d5
@jurmy24
Refactor: use enums instead of individual enum type names
568b998
@jurmy24
Refactor: move WIP flows functions into the scripts folder
9497315
@jurmy24
Refactor: move the request handler for flows into the flow_service
ec1b900
@jurmy24
Misc: improve conciseness by getting rid of background tasks
8cbd84c
@jurmy24
Fix: removed formatting issue in the classes flow data exchange
caa04f1
@jurmy24
Misc: remove comment
385e3f9
@jurmy24
Feat: add read operation for subject and classes
22dc9f7
@jurmy24
Db: remove status for subjects
fd69d92
@jurmy24
Feat: complete flow review
dbcb4d9
@jurmy24 jurmy24 added the enhancement New feature or request label Nov 28, 2024
@jurmy24 jurmy24 added this to the Release v0.1.0 milestone Nov 28, 2024
@jurmy24 jurmy24 requested a review from fredygerman November 28, 2024 10:07
@jurmy24 jurmy24 linked an issue Nov 30, 2024 that may be closed by this pull request
[Feature]: Resource ingestion pipeline to the vector database #43
Closed
@jurmy24 jurmy24 removed a link to an issue Nov 30, 2024
[Feature]: Resource ingestion pipeline to the vector database #43
Closed
@jurmy24 jurmy24 merged commit 8cbdd5f into development Dec 3, 2024
4 checks passed
@jurmy24 jurmy24 deleted the jurmy24/development/flow-review branch December 3, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredygerman fredygerman Awaiting requested review from fredygerman

Assignees

@jurmy24 jurmy24

@fredygerman fredygerman

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jurmy24 @fredygerman